Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone guides POC #193

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Standalone guides POC #193

wants to merge 8 commits into from

Conversation

ggam
Copy link
Member

@ggam ggam commented Apr 26, 2020

Fixes #192. Requires #191.

This is a very early POC, just for getting feedback. Preview is available at http://www.ggam.eu/jakartaee-tutorial/guides/

I've presented concepts basically in the order they are explained in the full tutorial and arbitrarily grouped it based on personal criteria.

Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
Signed-off-by: Guillermo González de Agüero <z06.guillermo@gmail.com>
@keilw
Copy link
Member

keilw commented Jun 28, 2020

This is still a draft, I trust the other one can be merged sooner, this one also had over 1k files changed.

@ggam ggam mentioned this pull request Jun 28, 2020
@ggam
Copy link
Member Author

ggam commented Jun 28, 2020

This branch is indeed based on #191 and only makes some additional changes: ggam/jakartaee-tutorial@jbakeless...ggam:split-guides

@keilw keilw requested a review from arjantijms May 3, 2021 08:33
@keilw
Copy link
Member

keilw commented May 3, 2021

@ggam Is this something related to either Jakarta EE 8 support or 9 or is it independent?

@ggam
Copy link
Member Author

ggam commented May 3, 2021 via email

@arjantijms
Copy link
Contributor

@ggam I just merged the Jakarta EE 9 changes ;)

Copy link
Contributor

@arjantijms arjantijms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good start, even though POC, let's go ahead with this.

@arjantijms
Copy link
Contributor

@ggam what shall we do with this PR? This hasn't been updated for almost 2 years.

@ggam
Copy link
Member Author

ggam commented Mar 8, 2022

Main problem it has it that cross-document links don't work. I thought those were automatically fixed by @hussainnm changes but I've just checked and the problem is still there.

Anyway, since this doesn't change the actual contents of the tutorial and it's just an addition to the existing structure, it should be good to merge for now.

@ggam ggam marked this pull request as ready for review March 8, 2022 23:19
@arjantijms
Copy link
Contributor

Thanks @ggam, now the only thing is that the build mysteriously fails. Can you try to just re-run it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split the tutorial into standalone guides
3 participants